[Webkit-unassigned] [Bug 42324] WebKitTestRunner needs testRunner.dumpDOMAsWebArchive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42324





--- Comment #4 from Tim Horton <timothy_horton at apple.com>  2013-05-06 18:41:03 PST ---
(From update of attachment 200863)
View in context: https://bugs.webkit.org/attachment.cgi?id=200863&action=review

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:843
> +    // create web archive data from the frame

Comments should start with capital letters and end with punctuation.

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:849
> +    CFDataRef cfData = CFDataCreate(0, bytes, length);

I find it vaguely surprising we don't have a better way to make a CF/NSData from a WKData, but perhaps we don't.

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:850
> +    CFStringRef cfString = createXMLStringFromWebArchiveData(cfData);

No clear need for this local.

> Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:1
> +/*

It would of course be nice not to copy these files, but Sam and Alex and I don't really know of a good shared place.

> Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h:38
> +CFURLResponseRef createCFURLResponseFromResponseData(CFDataRef responseData);

You mentioned that we might not need this. If you find out that you don't, can you remove it from the copied files?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.