[Webkit-unassigned] [Bug 42324] WebKitTestRunner needs testRunner.dumpDOMAsWebArchive

Mon May 6 18:36:36 PDT 2013

https://bugs.webkit.org/show_bug.cgi?id=42324

WebKit Commit Bot <commit-queue at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |commit-queue at webkit.org

--- Comment #3 from WebKit Commit Bot <commit-queue at webkit.org>  2013-05-06 18:35:00 PST ---
Attachment 200863 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl', u'Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp', u'Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h', u'Tools/WebKitTestRunner/InjectedBundle/TestRunner.h', u'Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj', u'Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp', u'Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h', u'Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm']" exit_code: 1
Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:35:  The parameter name "response" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:36:  The parameter name "response" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:37:  The parameter name "response" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:38:  The parameter name "response" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:39:  The parameter name "response" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:152:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:230:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Total errors found: 8 in 9 files

If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.