[Webkit-unassigned] [Bug 115556] [CMake] Don't compile SVG/MATHML files if they are not enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115556





--- Comment #10 from Mark Salisbury <mark.salisbury at hp.com>  2013-05-06 16:42:18 PST ---
(In reply to comment #6)
> SVG and MathML files are guarded using ENABLE() macro by itself. Isn't this overlapping guard ? As far as I know, GNUMakefile doesn't use ENABLE() guard for the files as well. If we maintain files using ENABLE() in CMake, same file sometimes was added to it. However, there was no big opinion not to use ENABLE() in CMake. If there is big time difference when using ENABLE(), I think we can use it. If not, I prefer to keep it as it is.

It is an overlapping guard.  If we had a single build system (CMake), we could take my patch and then remove the #if ENABLE(SVG) guards in the SVG files.

However, we don't have a single build system.  Even if we did, I don't mind the #if ENABLE(SVG) in the source files (in addition to putting if(ENABLE_SVG) in cmake files).  I think they make them more readable and tell you that SVG has to be turned on or the code is ignored.  They tell someone who isn't familiar with SVG that it's safe NOT to compile the file when SVG is not enabled.

I measured the build savings at 3 minutes, that's not trivial.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.