[Webkit-unassigned] [Bug 115517] Selection in non-editable content gets stuck when approaching an editable node

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115517





--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2013-05-06 11:57:56 PST ---
(From update of attachment 200415)
View in context: https://bugs.webkit.org/attachment.cgi?id=200415&action=review

> Source/WebCore/editing/VisiblePosition.cpp:457
> +    // Move to previous non-editable region if this position is non-editable, but pos is editable

This is not a what comment. We need to explain why we want to move back to the previous position.

> Source/WebCore/editing/VisiblePosition.cpp:458
> +    // FIXME: We skip non-editable regions inside the lowestEditableAncestor of pos for simplicity.

I don’t understand this FIXME. It seems like this is just stating the current behavior.
FIXME should mention what needs to be fixed.

> Source/WebCore/editing/VisiblePosition.cpp:492
> +    // Move to the next non-editable region if this position is non-editable, but pos is editable
> +    // FIXME: We skip non-editable regions inside the lowestEditableAncestor of pos for simplicity.
> +    if (!highestRoot) {

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.