[Webkit-unassigned] [Bug 114809] [WK2][GTK] ExceededDatabaseQuota method support in WebKitUIClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114809





--- Comment #25 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-05-06 09:45:01 PST ---
(From update of attachment 200076)
View in context: https://bugs.webkit.org/attachment.cgi?id=200076&action=review

I don't know much about web database, but I wonder if it would make more sense to expose web database API and expose methods to get/set the web database quota per security origin, using a default value like webkit1 did.

>> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:68
>> +    guint64 defaultWebDatabaseQuota;
> 
> You shoult use int64_t here, if possible.

Actually uint64_t

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1087
> +     */

Since: 2.2

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1093
> +            0, G_MAXUINT64, 5 * 1024 * 1024,

We could probably use a global static var or a macro for the default value.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1159
> + **/

Use single * here, and add Since: 2.2 tag

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1172
> + **/

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:199
> -        0, // exceededDatabaseQuota
> +        decidePolicyForExceededDatabaseQuotaPermissionRequest,

We don't usually rename the callbacks, it makes easier to match callback name and its implementation,

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.