[Webkit-unassigned] [Bug 115513] Improving PageSerializer.cpp to retrieve the subresources specified in @media rules in css

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 6 06:41:29 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=115513





--- Comment #30 from Andreas Kling <akling at apple.com>  2013-05-06 06:39:52 PST ---
(From update of attachment 200642)
View in context: https://bugs.webkit.org/attachment.cgi?id=200642&action=review

> Source/WebCore/ChangeLog:17
> +        Test file : This code is triggred by external UI interface to save
> +        page as mhtml format(chromium save page in mhtml and safari add to
> +        Reading list).So The automated test case for this code cant be
> +        produced.
> +        for Test case and Patch results(with and without) in chromium can be seen at 
> +        attachement at https://bugs.webkit.org/show_bug.cgi?id=115513

Wait, so you're saying that this code is currently unreachable?

> Source/WebCore/page/PageSerializer.cpp:281
> +            Vector<RefPtr<StyleRuleBase> > rules = mediaStyle->childRules();

You can avoid reffing and dereffing every StyleRuleBase here by using a const reference:
const Vector<RefPtr<StyleRuleBase> >& rules = mediaStyle->childRules();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list