[Webkit-unassigned] [Bug 115513] Improving PageSerializer.cpp to retrieve the subresources specified in @media rules in css

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 5 19:39:32 PDT 2013


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #200601|review?                     |review-
               Flag|                            |

--- Comment #27 from Benjamin Poulain <benjamin at webkit.org>  2013-05-05 19:37:55 PST ---
(From update of attachment 200601)
View in context: https://bugs.webkit.org/attachment.cgi?id=200601&action=review

> I had attached the test patch before with name Test.html and respective saved file in mhtml Test.mhtml from chromium (one Image is not saved in Test.mhtml file)). Isn't is enough ??
> Should I attach agin same Test.html again.
> Actually I am not very used to bugzilla (this is my first time), so plz guide.

Manual test attached on bugzilla are irrelevant for a patch. You need to have an automated test with your patch.

Typically tests are written as LayoutTest or API tests. I am unfamiliar with the testing of PageSerializer, you will probably find how it is tested by looking at the previous changes on that class.

> Source/WebCore/page/PageSerializer.cpp:285
> +                RefPtr<StyleRuleBase> rule = rules[i];

This should be a reference to avoid the ref(). (or alternatively get the pointer in the temporary).

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list