[Webkit-unassigned] [Bug 95178] Support CSS3 Keyboard control

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95178


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #200300|review?                     |review-
               Flag|                            |




--- Comment #26 from Andreas Kling <akling at apple.com>  2013-05-05 12:57:08 PST ---
(From update of attachment 200300)
View in context: https://bugs.webkit.org/attachment.cgi?id=200300&action=review

It sounds like we shouldn't be implementing this at all. Regardless, r- because this should be behind an ENABLE-flag, and new features should be announced on webkit-dev.

> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:206
> +    DataRef<StyleNavDirection> m_navUp;
> +    DataRef<StyleNavDirection> m_navDown;
> +    DataRef<StyleNavDirection> m_navLeft;
> +    DataRef<StyleNavDirection> m_navRight;
> +    DataRef<StyleNavIndex>     m_navIndex;

I don't like the idea of growing StyleRareNonInheritedData by 5 whole pointers for a single feature that's not used on the web yet. Can we make group this stuff under a single pointer here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.