[Webkit-unassigned] [Bug 115589] Move IdentifierASCIIStringTranslator to WTF

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 4 21:19:04 PDT 2013


--- Comment #5 from Benjamin Poulain <benjamin at webkit.org>  2013-05-04 21:17:27 PST ---
(In reply to comment #4)
> So exposing StringImpl::setHash would obviously fix all layering violations here, and we'd done. I assumed there were good reasons to avoid that, but if the are not we can just do it.
> Otherwise I guess I can try to figure out how to generalize all this stuff in a StringHashTranslator class as you suggest in bug #115593.

setHash is private in order to be defensive since only a a few classes should do that (mostly Translators and AtomicString).

I guess we could have on abstract StringHash that is a friend of StringImpl and with a protected method to set the hash. What do you think?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list