[Webkit-unassigned] [Bug 115352] Make sure gstreamer source element is thread-safe

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 3 11:42:52 PDT 2013


--- Comment #14 from Philippe Normand <pnormand at igalia.com>  2013-05-03 11:41:14 PST ---
(From update of attachment 200022)
View in context: https://bugs.webkit.org/attachment.cgi?id=200022&action=review

> Source/WebCore/ChangeLog:3
> +        Make sure gstreamer source element is thread-safe.

Sorry to be annoying about this but the  Changelog entry   format is not correct, please check other entries. Usually thee structure is:

bug title
bug link

Reviewed by...

description of change

> Source/WebCore/ChangeLog:15
> +        No new tests (OOPS!).

If no new test is added please remove this line.

> Source/WebCore/ChangeLog:18
> +        (_WebKitWebSrcPrivate):

It would bee good, I think, to have a little summary of each function/method change.

>>> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:865
>>> +    GST_OBJECT_UNLOCK(src);
>> I think these locks are actually unnecessary, as that function will only be called right after creating the instance and then never again. But they don't hurt
> Yeah, not change here, but let me know if you want me to remove these extra locks, I wouldn't mind tbh, they won't hurt anyway :)

Right, please remove these locks :)

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1075
> +    uri = g_strdup(m_src->priv->uri);

I think it'd make sense to use a GOwnPtr<gchar> here

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1089
> +    uri = g_strdup(m_src->priv->uri);


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list