[Webkit-unassigned] [Bug 114742] [texmap] draw content if graphics layer displays a video

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114742





--- Comment #21 from Víctor M. Jáquez L. <vjaquez at igalia.com>  2013-05-03 09:56:36 PST ---
Hi Noam!

Thanks a lot for your review.

(In reply to comment #19)
> (From update of attachment 200400 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=200400&action=review
> 
> Where is the code that uses the new function?

It is used in this patch for bug #86410

https://bugs.webkit.org/attachment.cgi?id=200421&action=review

> 
> > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:112
> > +    virtual void setLayerNeedsDisplay() { setContentsNeedsDisplay(); }
> 
> Let's call this setPlatformLayerNeedsDisplay?
> Also add OVERRIDE.

Done

> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h:47
> > +    void setClient(TextureMapperPlatformLayer::Client* client) { m_client = client; }
> 
> Maybe new line before and after?

Done

> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h:56
> > +    void setLayerNeedsDisplay()
> 
> I think this should be done in the actual layer implementation.

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.