[Webkit-unassigned] [Bug 115352] Make sure gstreamer source element is thread-safe

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 3 03:14:10 PDT 2013


--- Comment #12 from Sebastian Dröge <slomo at circular-chaos.org>  2013-05-03 03:12:32 PST ---
(From update of attachment 200022)
View in context: https://bugs.webkit.org/attachment.cgi?id=200022&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:453
> +            gst_app_src_set_size(priv->appsrc, -1);

Any reason why you move these at the very end?

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:-632
> -    return g_strdup(WEBKIT_WEB_SRC(handler)->priv->uri);

A const gchar* function returning a copy a copy of a string? That looks wrong, but it was like that before already :) But then this is 0.10 code, which was broken exactly because of things like this. So decide for yourself if you want to leak here or potentially crash

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:865
> +    GST_OBJECT_UNLOCK(src);

I think these locks are actually unnecessary, as that function will only be called right after creating the instance and then never again. But they don't hurt

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list