[Webkit-unassigned] [Bug 111513] Create a script to import W3C tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 1 22:18:14 PDT 2013


Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #200295|review?                     |review+
               Flag|                            |

--- Comment #20 from Dirk Pranke <dpranke at chromium.org>  2013-05-01 22:16:36 PST ---
(From update of attachment 200295)
View in context: https://bugs.webkit.org/attachment.cgi?id=200295&action=review

Looks pretty good, so I'm R+'ing it with a few more nits. Feel free to fix those and land w/o another review. Once we do that, if you want to use this script to import specific subdirs I think that's great but we should probably do so on an ad-hoc basis into someplace *other* than where we might want the long-term location of the whole w3 repo to be.

In other words, if we end up wanting to put the w3c's tests in LayoutTests/w3c/... , don't import submitted/adobe/regions (or whatever) into LayoutTests/w3c/submitted/adobe/regions directly. You should probably have me review the first import or two just to see how it goes.

Thanks so much for working on this!

> Tools/Scripts/import-w3c-tests:3
> +# Copyright (C) 2010 Apple Inc. All rights reserved.

copyright :)

> Tools/Scripts/webkitpy/w3c/test_converter.py:31
> +from webkitpy.thirdparty.BeautifulSoup import Tag

nit: list the standard modules first, then the stuff from webkitpy.thirdparty. Also, you can (and should) do "import BeautifulSoup, Tag"

> Tools/Scripts/webkitpy/w3c/test_converter.py:47
> +

nit: don't put a blank line here.

> Tools/Scripts/webkitpy/w3c/test_importer.py:109
> +

nit: don't put blank lines between your method declarations and the body of the methods.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list