[Webkit-unassigned] [Bug 115448] ipc-posix-shm backwards compatibility

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115448





--- Comment #5 from Simon Cooper <scooper at apple.com>  2013-05-01 14:48:20 PST ---
(In reply to comment #2)
> (From update of attachment 200194 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=200194&action=review
> 
> r=me
> 
> > Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:250
> > +(if (not (defined? 'ipc-posix-shm*))
> > +    (define ipc-posix-shm* ipc-posix-shm))
> 
> I wish we pre-processed plug-in sandbox profile files, so that we could do conditional compilation. With an #if check, removing obsolete code is much more straightforward.

This isn't obsolete code -- it provides backwards compatibility.

> Also, we wouldn't have to merge parts at runtime, as we could simply #include "com.apple.WebKit.plugin-common.sb", and let preprocessor build a complete profile.

This is not a good idea. 

- This will not work if the AppleConnect profile is moved to a different project.

- Forcing cpp preprocessing means that some sort of  "compilation step" has to occur before passing to sandbox which makes it harder to develop and debug profiles.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.