[Webkit-unassigned] [Bug 70117] Expose HTMLCanvasElement supportsContext

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 31 13:41:45 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=70117





--- Comment #19 from Ruth Fong <ruthiecftg at gmail.com>  2013-05-31 13:40:16 PST ---
(From update of attachment 203462)
View in context: https://bugs.webkit.org/attachment.cgi?id=203462&action=review

>> Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:123
>> +            if (jsAttrs->hasProperty(exec, preserveDrawingBuffer))
> 
> These toBooleans() can all throw exceptions, so we should probably be checking for exceptions.  We should also make sure we are testing all those cases as well.  Can this use a JSDictionary to simplify things?

Right now JSHTMLCanvasElement::getContext is implemented like this (without exception handling) - should I still add exception handling?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list