[Webkit-unassigned] [Bug 117077] platformplugin install directory fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 31 08:56:49 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=117077





--- Comment #1 from Matthew Jones <mrjones at live.com>  2013-05-31 08:55:21 PST ---
Created an attachment (id=203451)
 --> (https://bugs.webkit.org/attachment.cgi?id=203451&action=review)
Fixes build and install directory for platformplugin

When building the platformplugin library the variable DESTDIR is defined.  When Qt reads the platformplugin.pro file it defines DESTDIR in the Makefile.  This has a couple of side affects.

1) The library libplatformplugin.so doesn't seem to be built when DESTDIR in the platformplugin.pro file is defined.
2) If the user has sufficient privileges (eg. root or sudo) then this would create an install directory in the location of $QT_INSTALL_PLUGINS/webkit with whatever location $QT_INSTALL_PLUGINS is defined as in the systems /.  If the user tries to build to a temporary root (eg. /tmp) then this will ignore whatever INSTALL_ROOT or DESTDIR variable is given during the 'make install' phase.

The patch adds the proper variables so that libplatformplugin.so gets built to the sources local 'release/' directory (or 'debug/' depending on build type) as that is the value of DESTDIR in the Makefile if it is not defined in platformplugin.pro.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list