[Webkit-unassigned] [Bug 116689] Regression(r145959) Convert <select> to new flex box causes strange positioning problems

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116689





--- Comment #18 from Roger Fong <roger_fong at apple.com>  2013-05-30 19:41:16 PST ---

> Yeah. It's a valid concern. It wouldn't surprise me if there's other bugs like this one hiding here. You could add an ASSERT(!gDelayUpdateScrollInfo) to layoutOverflowRect as well.

Okay, yeah, I'll try that and see if I hit it anywhere.


> I think those should be calling RenderBlock's udpateScrollInfoAfterLayout.

Sounds good.

> Hmmm...I'm not sure about this. Might want to get Hyatt to take a look at this first. Thinking about this more, it might be wrong to clear m_overflow if !hasControlClip(). I'm not sure.

I added :
    if (!hasControlClip())
        return;
to the top of clearLayoutOverflow() to maintain old behaviour.

Without that there, we get some failing tests, like, fast/overflow/height-during-simplified-layout.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.