[Webkit-unassigned] [Bug 117050] Get rid of Javascript Exports file on Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 30 16:36:21 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=117050





--- Comment #2 from WebKit Commit Bot <commit-queue at webkit.org>  2013-05-30 16:34:53 PST ---
Attachment 203395 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.submit.sln', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreCommon.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorBuildCmd.cmd', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorDebug.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPreBuild.cmd', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorProduction.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorRelease.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/make-export-file-generator', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/jsc/jscCommon.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/testapi/testapiCommon.props', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.vcxproj/WTFCommon.props', u'Source/WTF/wtf/DateMath.h', u'Source/WTF/wtf/ExportMacros.h', u'Source/WTF/wtf/FilePrintStream.h', u'Source/WTF/wtf/OSAllocator.h', u'Source/WTF/wtf/PageAllocationAligned.h', u'Source/WTF/wtf/Platform.h', u'Source/WTF/wtf/PrintStream.h', u'Source/WTF/wtf/StackBounds.h', u'Source/WTF/wtf/StringPrintStream.h', u'Source/WTF/wtf/ThreadSpecific.h', u'Source/WTF/wtf/WTFThreadData.h', u'Source/WTF/wtf/dtoa/cached-powers.h', u'Source/WTF/wtf/dtoa/double-conversion.h', u'Source/WTF/wtf/text/WTFString.h', u'Source/WTF/wtf/unicode/Collator.h', u'Source/WTF/wtf/unicode/UTF8.h', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.vcxproj/WebKit.sln', u'Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props', u'Tools/ChangeLog', u'Tools/DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props', u'Tools/DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props', u'Tools/TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props']" exit_code: 1
Source/WTF/wtf/OSAllocator.h:60:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WTF/wtf/unicode/UTF8.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WTF/wtf/PageAllocationAligned.h:44:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WTF/wtf/PageAllocationAligned.h:44:  The parameter name "usage" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list