[Webkit-unassigned] [Bug 115647] [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115647





--- Comment #20 from Eduardo Lima Mitev <elima at igalia.com>  2013-05-30 02:30:44 PST ---
(In reply to comment #19)
> You're bumping the ATK dependency to >= 2.7.90 without fixing any bugs
> or adding new functionality, which restricts the number of potential
> users:
>

I understand that, but right now the fix of this patch is becoming more a code cleaning issue. We are centralizing the implementation of language() methods from DumpRenderTree and WebKitTestRunner, into WebCore, using the AtkObject::get_object_locale(), provided for that specific purpose. Right now that implementation is basically duplicated, and poorly encapsulated.

Also, there is a memory leak in the DumpRenderTree version of language(), that I'm now fixing as part of moving the implementation to WebCore.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.