[Webkit-unassigned] [Bug 116863] Share FontGlyphs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116863





--- Comment #23 from Antti Koivisto <koivisto at iki.fi>  2013-05-29 07:47:23 PST ---
> > Source/WebCore/css/CSSFontSelector.cpp:69
> > +    , m_uniqueId(++fontSelectorId)
> 
> Can't this overflow? You're not even using a 64-bit type!

Yeah, in theory though that would take a while. Also it is unlikely that any fonts from a colliding font selector are alive at that point. If that happens you may get a wrong font.

> > Source/WebCore/css/CSSFontSelector.cpp:631
> > +        DEFINE_STATIC_LOCAL(String, webkitPrefix, ("-webkit-"));
> > +        if (familyName.startsWith(webkitPrefix))
> > +            return true;
> 
> String::startsWith() has a nice overload for this, it's better to just check startsWith("-webkit-")

Ok. Didn't know that.

> 
> > Source/WebCore/css/CSSFontSelector.h:54
> > +    virtual ~CSSFontSelector() FINAL OVERRIDE;
> 
> ... na-na nah nah naaaaaa!
> 
> Sorry to ruin the '80s song, but we should just mark the class FINAL instead of doing it to every virtual method.

:(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.