[Webkit-unassigned] [Bug 116948] New: Don't assert when serializing -mask property

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 29 02:02:12 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=116948

           Summary: Don't assert when serializing -mask property
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: koivisto at iki.fi, akling at apple.com


Consider merging https://chromium.googlesource.com/chromium/blink/+/e7cb696218908a4f90aac57889f91d92e6d1af0b

In the case -webkit-mask property contains several layers, it is possible
that one of the layer contains "initial" implicitly set simply because the
repeat property was not specified. However when reconstructing the
mask property from StylePropertySet it is possible to have for example
-mask-repeat-x with a value like 'initial, repeat-x' where the first initial
is implicit (the original -mask first layer did not set it). As
StylePropertySet should not return implicitly set initial values we should
just omit these ones. The ASSERT was triggered because of better checks before
casting to CSSPrimitiveValues but in this example we should not reach that
cast, we should bail out : 'initial' is not a primitive value.

We need to merge this into StylePropertySet::getLayeredShorthandValue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list