[Webkit-unassigned] [Bug 116933] New: getData16SlowCase shows up on Mobile Gmail profile

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 29 01:08:44 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=116933

           Summary: getData16SlowCase shows up on Mobile Gmail profile
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: Page Loading
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: koivisto at iki.fi, benjamin at webkit.org,
                    psolanki at apple.com


Consider merging https://chromium.googlesource.com/chromium/blink/+/0d0e52b5e2d15baadb7703028e83e6736751830b

When loading Mobile Gmail in content_shell, StringImpl::getData16SlowCase shows
up as 0.35% of the total profile. We're hitting this code path because the HTML
parser causes *all* character tokens to (temporarily) have 16 string buffers
because ExternalCharacterTokenBuffer operates in terms of UChar*, which
assumes a 16 bit string buffer.

This CL changes CharacterTokenBuffer to operate in terms of offsets into
Strings, which is agnostic as to the backing buffer for the String. As a
result, we can often just use the HTMLTokenizer-generated String in the DOM
directly.

After this CL, getData16SlowCase doesn't show up on the profile at all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list