[Webkit-unassigned] [Bug 116923] New: Replace reattachIfAttached calls with lazyReattachIfAttached

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116923

           Summary: Replace reattachIfAttached calls with
                    lazyReattachIfAttached
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: hyatt at apple.com, koivisto at iki.fi,
                    simon.fraser at apple.com, akling at apple.com


Consider merging https://chromium.googlesource.com/chromium/blink/+/53ff5c99564ef1677df4f3575a206d32557e0eaa

We should always use lazyAttach instead of manually causing reattaches.
reattachIfAttached is bad because it encourages manual reattaching instead
of letting the next style recalc handle it for you which can result in
bad performance. For example setting and unsetting the open attribute on
<dialog> elements causes the synchronous destruction and recreation of the
entire renderer subtree repeatedly. This change makes sure that we defer all
that work until the next style recalc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.