[Webkit-unassigned] [Bug 113221] prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113221





--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2013-05-28 16:40:34 PST ---
(From update of attachment 202632)
View in context: https://bugs.webkit.org/attachment.cgi?id=202632&action=review

>> Tools/Scripts/prepare-ChangeLog:947
>> +        if (!(my ($matched) = grep $_ eq $function_name, @$namespaces))
> 
> This line is one of those wonderful unparseable-by-a-human lines of perl. Can we split it out into a few so I can tell what's going on?

Yeah, we should declare $matched outside of the if statement.
Also, if we're already using grep, why don't we just let grep generate new_ranges for us?
e.g. http://stackoverflow.com/questions/3960028/how-can-i-filter-an-array-without-using-a-loop-in-perl

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.