[Webkit-unassigned] [Bug 116096] DOMFileSystemBase: merge BlackBerry implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116096


Alberto Garcia <agarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202793|0                           |1
        is obsolete|                            |
 Attachment #203068|                            |review?, commit-queue?
               Flag|                            |




--- Comment #9 from Alberto Garcia <agarcia at igalia.com>  2013-05-28 10:55:08 PST ---
Created an attachment (id=203068)
 --> (https://bugs.webkit.org/attachment.cgi?id=203068&action=review)
Patch

(In reply to comment #8)
> The path.isEmpty() check here is redundant. Please remove it. I
> think I made this same comment on an earlier version of this patch.

You're right, sorry!

I've just uploaded a new patch addressing all the other issues that
you mentioned.

temporaryPathPrefix and friends are public constants exported from the
header file, so we cannot really change them.

For this new patch I used String::substringSharingImpl(), which is
more efficient and allows us to use startsWith() to check the prefix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.