[Webkit-unassigned] [Bug 112615] [css3-text] Implement support for vertical writing mode in -webkit-text-underline-position

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112615





--- Comment #9 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2013-05-27 04:27:04 PST ---
(In reply to comment #5)
> I did not have time to review all the patch, so I will write only the things I spotted in the first glance:
> 
> View in context: https://bugs.webkit.org/attachment.cgi?id=202797&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        because these line should ignore veritcal-align like under underline in horizontal writing mode.
> 
> typo: "veritcal-align"

Fixed.

> > Source/WebCore/rendering/InlineTextBox.cpp:1011
> > +    default:
> 
> Do not move this code into the default statement. Read comment https://bugs.webkit.org/show_bug.cgi?id=102795#c63 about this.

Fixed.

> > LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-right-left-horizontal.html:26
> > +<span class="decoration" style="color: cyan; -webkit-text-underline-position: left right;">left right :p The line should be alphabetic.</span>
> 
> This is an invalid value. It is ok that your patch defaults to alphabetic here. However, your patch should update LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position.html to check for this and other invalid values.

Added test cases to getComputedStyle-text-underline-position.html.
I found that I should implement CSSValueList behavior, so I implemented it.

>  Anything that is not either "auto", "alphabetic", "under", "under left" or "under right" is invalid.

This is not correct.
"left under" and "right under" are also valid value.
There is the definition of || in CSS2.1[1]
> A double bar (||) separates two or more options: one or more of them must occur, in any order.

This says "in any order", so we can write "left under" or "right under".

[1]: http://www.w3.org/TR/CSS21/about.html#property-defs

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.