[Webkit-unassigned] [Bug 116717] [GTK] Do not use X11 WidgetBackingStore implementation in Wayland

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 27 03:19:18 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=116717


Iago Toral <itoral at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202804|0                           |1
        is obsolete|                            |




--- Comment #3 from Iago Toral <itoral at igalia.com>  2013-05-27 03:17:48 PST ---
Created an attachment (id=202961)
 --> (https://bugs.webkit.org/attachment.cgi?id=202961&action=review)
Proposed patch

This patch does the same as the previous one but handles the wk2 case properly. Some considerations:

1) I have concentrated the run-time decision about the backend to use (cairo or x11) in WidgetBackingStore::create.
2) WidgetBackingStore.cpp is part of libwebcoregtk , and hence needs to be built with GTK2 and GTK3 even if I understand there is no case in which the plugin process would use the WidgetBackingStore. The fallback case is to use the Cairo implementation.
3) I am not sure that WidgetBackingStore.{h,cpp} should live in WebCore/platform/cairo, would WebCore/platform be a better place?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list