[Webkit-unassigned] [Bug 116755] CSSParser::parseImageResolution doesn't need a parameter.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 26 18:10:35 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=116755





--- Comment #3 from Jaehun Lim <ljaehun.lim at samsung.com>  2013-05-26 18:09:05 PST ---
(From update of attachment 202874)
View in context: https://bugs.webkit.org/attachment.cgi?id=202874&action=review

>> Source/WebCore/css/CSSParser.cpp:2983
>>          m_valueList->next();
> 
> This line of code does not seem necessary. The parseImageResolution function already kept calling next() until it returned 0. This line of code does nothing.

Yes.
I think "if (!parsedValue) / return false;" are redundant, too. parsedValue will be checked after switch case statement.
I'll remove these two lines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list