[Webkit-unassigned] [Bug 116783] Use Vector instead of custom linked list for font families

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116783





--- Comment #2 from Andreas Kling <akling at apple.com>  2013-05-26 05:32:56 PST ---
(From update of attachment 202915)
View in context: https://bugs.webkit.org/attachment.cgi?id=202915&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

OOPS!

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1450
>  static PassRefPtr<CSSValueList> fontFamilyFromStyle(RenderStyle* style)
> -{
> -    const FontFamily& firstFamily = style->fontDescription().family();
> +    {

Strange indentation here.

> Source/WebCore/rendering/RenderText.cpp:211
> -    } else if (oldStyle->font().needsTranscoding() != newStyle->font().needsTranscoding() || (newStyle->font().needsTranscoding() && oldStyle->font().family().family() != newStyle->font().family().family())) {
> +    } else if (oldStyle->font().needsTranscoding() != newStyle->font().needsTranscoding() || (newStyle->font().needsTranscoding() && oldStyle->font().fontDescription().families() != newStyle->font().fontDescription().families())) {

You're now comparing all families here instead of just the first one. Looks wrong.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.