[Webkit-unassigned] [Bug 76048] [GTK] fast/text/font-kerning.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76048





--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2013-05-23 07:43:00 PST ---
(From update of attachment 202669)
View in context: https://bugs.webkit.org/attachment.cgi?id=202669&action=review

> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp:502
> +        if (m_font->fontDescription().kerning() == FontDescription::NoneKerning) {
> +            Vector<hb_feature_t, 5> features = m_features;
> +            hb_feature_t kerning = { HB_TAG('k', 'e', 'r', 'n'), 0, 0, static_cast<unsigned>(-1) };
> +            features.append(kerning);
> +            hb_shape(harfBuzzFont.get(), harfBuzzBuffer.get(), features.data(), features.size());
> +        } else

Hrm. A more likely location for this change is HarfBuzzShaper::setFontFeatures where the rest of the feature are set, no? Aren't you also adding 'kern' to the feature list here instead of removing it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.