[Webkit-unassigned] [Bug 115944] Add CMake base build system for WinCairo port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115944





--- Comment #3 from Mark Salisbury <mark.salisbury at hp.com>  2013-05-22 14:54:22 PST ---
(In reply to comment #2)
> (From update of attachment 201439 [details])
> Please reuse the WinCE files too: See https://github.com/paroga/webkit/commit/0b6c0bafbb02d7ef50914f8895de5d85265598e3

Patrick - can you explain what you mean by "reuse the WinCE files too"?

I looked at your private branch and believe your design is:
- make each windows port a separate port (WinCairo, WinCE, eventually WinApple)
- a port can define what the parent port (fallback port) is, the fallback port is included first then the port file is included

I could modify my patch to go this route.  Currently with my patch you set PORT=Win, PORT_FLAVOR=WinCairo.  I could adopt your approach with minimal turmoil; the common build files would know to include an Options{fallback}.cmake and the files I've set up should work.

I want to add support for WinCE in these steps (ultimately my vision is to build WinCairo for WinCE with the same - perhaps a few exceptions - set of source files used to build for Windows XP):

1) Add a CMake port for WinCairo.
2) Make it possible to build WinCairo without CoreFoundation.
3) Upstream cairo changes to support WinCE.
4) Make changes to build WinCairo for WinCE.

> Also rebase your patch (e.g. pthread isn't required anymore) and make additional patches for the changes in the CPP files.

FastMalloc.cpp still requires pthreads when not USE_SYSTEM_MALLOC.

I just rebased, I'll attach that patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.