[Webkit-unassigned] [Bug 115028] [EFL] Add command line option to MiniBrowser to set cookies policy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115028





--- Comment #17 from Christophe Dumez <dchris at gmail.com>  2013-05-22 04:07:48 PST ---
(From update of attachment 202519)
View in context: https://bugs.webkit.org/attachment.cgi?id=202519&action=review

Looks much better IMHO.

> Tools/MiniBrowser/efl/main.c:1596
> +    if (strcmp(input_string, "always") == 0) 

We avoid comparison to 0 in WebKit. How about if (!strcmp())?

> Tools/MiniBrowser/efl/main.c:1598
> +    if (strcmp(input_string, "never") == 0)

Ditto.

> Tools/MiniBrowser/efl/main.c:1600
> +    if (strcmp(input_string, "no-third-party") != 0)

if (strcmp())

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.