[Webkit-unassigned] [Bug 95923] [EFL] Implement GCActivityCallback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95923





--- Comment #34 from Christophe Dumez <dchris at gmail.com>  2013-05-22 00:38:10 PST ---
(In reply to comment #32)
> (In reply to comment #30)
> > (From update of attachment 202500 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=202500&action=review
> > 
> > >> Source/JavaScriptCore/heap/HeapTimer.cpp:174
> > >> +    ecore_init();
> > > 
> > > Why do you need to call ecore_init() again though it is already called during the webprocess initialization ?
> > 
> > There's a binary to run in shell. That binary runs without ecore_init but ecore_timer is in GCActivityCallback.
> 
> If so, how about adding it to main() of Jsc.cpp ? I don't agree to call ecore_init() / ecore_shutdown() again here. I heard that there may be problems inside EFL when we call it twice.

if you ecore_init() more than once, it should merely increase a ref count and not do any processing.

--- Comment #35 from Hojong Han <hojong.han at samsung.com>  2013-05-22 00:38:11 PST ---
(From update of attachment 202500)
View in context: https://bugs.webkit.org/attachment.cgi?id=202500&action=review

>>>> Source/JavaScriptCore/heap/HeapTimer.cpp:174
>>>> +    ecore_init();
>>> 
>>> Why do you need to call ecore_init() again though it is already called during the webprocess initialization ?
>> 
>> There's a binary to run in shell. That binary runs without ecore_init but ecore_timer is in GCActivityCallback.
> 
> If so, how about adding it to main() of Jsc.cpp ? I don't agree to call ecore_init() / ecore_shutdown() again here. I heard that there may be problems inside EFL when we call it twice.

Good to move those in Jsc.cpp even if there isn't any specific problem when calling it more than twice as I know of :)

>> Source/JavaScriptCore/heap/HeapTimer.cpp:180
>> +    ecore_shutdown();
> 
> ditto.

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.