[Webkit-unassigned] [Bug 95923] [EFL] Implement GCActivityCallback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95923





--- Comment #29 from Christophe Dumez <dchris at gmail.com>  2013-05-22 00:08:29 PST ---
(From update of attachment 202500)
View in context: https://bugs.webkit.org/attachment.cgi?id=202500&action=review

>>>>> Source/JavaScriptCore/heap/HeapTimer.h:42
>>>>> +#include <Ecore.h>
>>>> 
>>>> A forward declaration of Ecore_Timer would suffice here. And this include can be moved to the cpp.
>>> 
>>> Do you mean that it'd better move "#include <Ecore.h>" to the cpp?
>> 
>> Yes, and have a forward declaration here:
>> typedef struct _Ecore_Timer Ecore_Timer;
> 
> HeapTimer.h is included in GCActivityCallback.h and there's Ecore_Task_Cb in GCActivityCallback.cpp.
> What do you think keeping it in HeapTimer.h?

No, please add the proper include to GCActivityCallback.cpp then.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.