[Webkit-unassigned] [Bug 95923] [EFL] Implement GCActivityCallback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95923





--- Comment #22 from Hojong Han <hojong.han at samsung.com>  2013-05-21 22:53:22 PST ---
(In reply to comment #21)
> (From update of attachment 202494 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202494&action=review
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        [EFL] Implement GCActivityCallback
> 
> It looks you need to change bug title according to new patch.

Title changed to match with the patch.

> > Source/JavaScriptCore/PlatformEfl.cmake:2
> > +    ${ECORE_X_INCLUDE_DIRS}
> 
> It looks you don't use ecore_x. So, ${ECORE_INCLUDE_DIRS} is enough.

yes, ECORE_INCLUDE_DIRS is enough. I'll change it.

> > Source/JavaScriptCore/runtime/GCActivityCallback.cpp:-105
> > -
> 
> Do not modify code unrelated to this patch.

It's just kind of improving readability, but no biggie whether keep it as it was.

> > Source/JavaScriptCore/runtime/GCActivityCallback.cpp:124
> > +    stop();
> 
> Why do you need to call stop() here ?

Doesn't it need to stop the previous before setting new one ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.