[Webkit-unassigned] [Bug 95923] [EFL] Implement GCActivityCallback with platform timer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95923





--- Comment #21 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-05-21 22:36:56 PST ---
(From update of attachment 202494)
View in context: https://bugs.webkit.org/attachment.cgi?id=202494&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        [EFL] Implement GCActivityCallback

It looks you need to change bug title according to new patch.

> Source/JavaScriptCore/PlatformEfl.cmake:2
> +    ${ECORE_X_INCLUDE_DIRS}

It looks you don't use ecore_x. So, ${ECORE_INCLUDE_DIRS} is enough.

> Source/JavaScriptCore/runtime/GCActivityCallback.cpp:-105
> -

Do not modify code unrelated to this patch.

> Source/JavaScriptCore/runtime/GCActivityCallback.cpp:124
> +    stop();

Why do you need to call stop() here ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.