[Webkit-unassigned] [Bug 114870] [GTK] Reimplement atk_text_get_text_*_offset for CHAR boundary

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114870





--- Comment #7 from Mario Sanchez Prada <mario at webkit.org>  2013-05-21 06:23:59 PST ---
(In reply to comment #6)
> Not sure I understand why this is still behind an #ifdef is the code can be shared now.

I just kept them there not to break EFL behaviour (even if so far it's just "being not implemented"), but I'm currently talking to EFL guys to see what it's best. Probably sharing it, as you mentioned.

In any case, another open question is whether we should move WebCore/accessibility to WebCore/platform/accessibility since, after all, a11y layer is pretty much a platform dependent thing.

Here's the compilation problem on EFL, I think:
> 
> [ 13%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/accessibility/atk/WebKitAccessibleInterfaceText.cpp.o
> /mnt/eflews/git/webkit/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:609:15: warning: unused parameter 'textPosition' [-Wunused-parameter]
> 

Argh! I should rebase my local branch it seems, to pick Edu's patch.

/mnt/eflews/git/webkit/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:578:15: error: 'gchar* webkitAccessibleTextGetChar(AtkText*, gint, GetTextRelativePosition, gint*, gint*)' defined but not used [-Werror=unused-function]
> cc1plus: all warnings being treated as errors
> make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/accessibility/atk/WebKitAccessibleInterfaceText.cpp.o] Error 1
> make[1]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/all] Error 2

That's what this last patch should have fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.