[Webkit-unassigned] [Bug 115880] [GTK] Connection issues in repeated WebProcess crash/reloads.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115880





--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-05-21 02:38:43 PST ---
(From update of attachment 201292)
View in context: https://bugs.webkit.org/attachment.cgi?id=201292&action=review

I think this patch is correct. It needs a ChangeLog entry, though.

> Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp:136
> +// WorkQueueGtk.cpp EventSource is in charge of closing the socket.

I would explain it a bit more here, because it's not obvious. The socket event source is going to be removed below, which will cancel the source. when the source is cancelled, the GSocket is destroyed and the socket is closed.

> Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:-115
> -    // Monitor the child process, it calls waitpid to prevent the child process from becomming a zombie,
> -    // and it allows us to close the socket when the child process crashes.
> -    g_child_watch_add(m_processIdentifier, childFinishedFunction, GINT_TO_POINTER(sockets[1]));
> -

Right, we added this when we used DGRAM sockets, ti shouldn't bee needed with STREAM sockets, since we are already notified when the other end closes the connection.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.