[Webkit-unassigned] [Bug 114862] [EFL][WK2]<select> element's text is clipped when a height is specified along with CSS line-height.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114862





--- Comment #14 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-05-20 01:30:32 PST ---
(From update of attachment 202066)
View in context: https://bugs.webkit.org/attachment.cgi?id=202066&action=review

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:-858
> -

Do not modify a line unrelated to this patch.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:879
> +    if (style->appearance() == MenulistPart || style->appearance() == MenulistButtonPart) {

As far as I know, this function can be called when appearance is MenulistButtonPart. So, this condition is not meaningful.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:880
> +        style->setPaddingTop(Length(dropDownBoxPaddingTop , Fixed));

Do not add a space in front of ,

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:881
> +        style->setPaddingRight(Length(dropDownBoxPaddingRight , Fixed));

ditto

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:882
> +        style->setPaddingBottom(Length(dropDownBoxPaddingBottom , Fixed));

ditto

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:883
> +        style->setPaddingLeft(Length(dropDownBoxPaddingLeft , Fixed));

ditto

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:884
> +        }

Wrong indentation.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:886
> +    // We need to set a control font size for EFL port when the font size specified in the content goes beyond certain value(i.e 12px)

ditto.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:888
> +        } 

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.