[Webkit-unassigned] [Bug 112913] [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112913





--- Comment #14 from Martin Robinson <mrobinson at webkit.org>  2013-05-17 11:45:51 PST ---
(From update of attachment 202052)
View in context: https://bugs.webkit.org/attachment.cgi?id=202052&action=review

> Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:58
> +#if PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
> +    return m_element.get();
> +#else
> +    return m_element;
> +#endif
> +}

I don't believe you need this #ifdef here. Doesn't GRefPtr should be support implicit casts to boolean?

> Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:66
> +#if PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
> +    return m_element.get();
> +#else
> +    return m_element;
> +#endif

This is a bit ugly...perhaps Mario is right and GRefPtr<...> should be typedef'd to PlatformUIElement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.