[Webkit-unassigned] [Bug 112913] [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112913





--- Comment #11 from Krzysztof Czech <k.czech at samsung.com>  2013-05-17 01:57:05 PST ---
(In reply to comment #10)
> (From update of attachment 201937 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=201937&action=review
> 
> > Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:252
> > +#if PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
> > +    GRefPtr<AtkObject> m_element;
> > +#else
> >      PlatformUIElement m_element;
> > +#endif
> 
> Would it be possible to update the typedef AtkObject* PlatformUIElement in this file to be typedef GRefPtr<AtkObject> PlatformUIElement, instead of changing this here?

Probably it would be feasible. It requires some additional casting code in AccessibilityController.cpp (rootElement and focusedElement methods)

I'm wondering, PlatformUIElement is used also as a constructor and function's parameter and a return value as well. Would it be too much refs and derefs of temporary objects ?. What to you think about it ?.

> 
> > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:283
> > +    return m_element.get() == otherElement->platformUIElement();
> 
> I think you don't need the .get() here
Right
> 
> > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:288
> > +    if (!m_element.get() || !ATK_IS_OBJECT(m_element.get()))
> 
> I don't think you need to use get() for checking !m_element.
Right

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.