[Webkit-unassigned] [Bug 116219] Fix Analyze ChangeLog's entry processing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 16 10:00:26 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=116219


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #201944|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2013-05-16 09:58:53 PST ---
(From update of attachment 201944)
View in context: https://bugs.webkit.org/attachment.cgi?id=201944&action=review

>>> Tools/Scripts/webkitpy/tool/commands/analyzechangelog.py:183
>>> +        i = 0
>> 
>> Instead of doing that, exit early when "not entries".
> 
> That was my first try, but the 'entries' is a generator. So to do the early exit first we need to ask for one element then check if there is any and do some magic with it.

I see. Makes sense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list