[Webkit-unassigned] [Bug 114960] Wrong text position when you click backspace on the line below the image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114960


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #201189|review?                     |review-
               Flag|                            |




--- Comment #28 from Ryosuke Niwa <rniwa at webkit.org>  2013-05-16 08:46:19 PST ---
(From update of attachment 201189)
View in context: https://bugs.webkit.org/attachment.cgi?id=201189&action=review

> Source/WebCore/ChangeLog:8
> +        Layout test added in separate patch: https://bug-114960-attachments.webkit.org/attachment.cgi?id=201183

Please combine that patch into this.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:1054
> +                    if (!insertAfterNode)
> +                        insertAfterNode = nodeToSplitTo.get();

This doesn't look right. We shouldn't be using the position after the nodeToSplit ever.
We probably need to get the position before the nodeToSplitTo in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.