[Webkit-unassigned] [Bug 116049] Add a DisplayNotificationObserver class to handle Display notifications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116049





--- Comment #34 from Roger Fong <roger_fong at apple.com>  2013-05-15 13:29:16 PST ---
> > Source/WebCore/platform/DisplayNotificationObserver.h:31
> > +#include <wtf/OwnPtr.h>
> > +#include <wtf/PassOwnPtr.h>
> 
> You're not using these two headers.

Oops, I am using OwnPtr though on m_internals.

> Why doesn't this set up the power-related stuff?

I think that's it's probably best to not having the Power and Display stuff together.
While it's true on mac that they both use IOKit, it may not be the case on any other platforms that the two are so closely knit, making the implementation awkward.

> Is the first parameter a 'context' param? Normally we'd use that to get to the target object, which would be cleaner than going through createSharedDisplayObserver().

It is! I will use that instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.