[Webkit-unassigned] [Bug 114862] [EFL][WK2]<select> element's text is clipped when a height is specified along with CSS line-height.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 14 03:48:36 PDT 2013


--- Comment #12 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-05-14 03:47:02 PST ---
(From update of attachment 201546)
View in context: https://bugs.webkit.org/attachment.cgi?id=201546&action=review

I think we're able to use specific padding values as window port if there is reasonable reason. However, this patch uses too work-around conditions looks like you fix specific problem for specific cases. See also other port's implementation. Even win port uses few conditions, for instance, to check height, direction or bgcolor, probably, it might be based on reasonable reason. But, you don't explain why we should use those conditions detailed. Please consider we should set padding values according to hacky conditions again.

>> Source/WebCore/platform/efl/RenderThemeEfl.cpp:858
>> +    if ((style->paddingTop().intValue() > desc->padding.top().intValue() &&  style->appearance() == MenulistButtonPart) || (style->paddingTop().intValue() > desc->padding.top().intValue() &&  style->appearance() == MenulistPart ))
> Too long line. line breaking is needed.

I don't see why do you handle MenulistButtonPart in here. Can't we handle it in adjustMenuListButtonStyle() ?

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:861
> +    else if (style->appearance() == MenulistPart || style->appearance() == MenulistButtonPart) {

Ditto. Why should we handle MenulistPart and MenulistButtonPart together in adjustMenuListStyle() ?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list