[Webkit-unassigned] [Bug 116096] New: DOMFileSystemBase: merge BlackBerry implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 14 03:32:12 PDT 2013


           Summary: DOMFileSystemBase: merge BlackBerry implementation
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: agarcia at igalia.com
                CC: xan.lopez at gmail.com, cgarcia at igalia.com,
                    leoyang at rim.com

As a follow-up to bug 114950, I think we can remove
DOMFileSystemBlackBerry.cpp completely if we do the necessary changes
to DOMFileSystemBase.cpp

Here is the situation:

- supportsToURL() and isValidType() can be directly removed from the
  BlackBerry file since the cross-platform implementation is

- crackFileSystemURL() adds code to deal with the cases where
  url.innerURL() is NULL. That's the case for non-GoogleURL, so I
  think we can just move this part to the cross-platform code.

  Actually, since there are no GoogleURLs anymore we can also remove
  KURL::innerURL() and all code that expects it to be non-NULL (I just
  checked, there's only a couple of cases).

- createFileSystemURL() has a slightly different implementation.

  I belive the cross-platform code is wrong, though:

  KURL url = m_filesystemRootURL;
  // Remove the extra leading slash.
  url.setPath(url.path() + encodeWithURLEscapeSequences(fullPath.substring(1)));

  The problem here is that KURL::setPath() adds a leading slash if it's
  not present, which converts this root URL




  Additionally, the cross-platform code strips the leading slash from
  fullPath. This doesn't work in BlackBerry because
  m_filesystemRootURL doesn't contain a trailing slash, but I think we
  can fix that easily.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list