[Webkit-unassigned] [Bug 105156] [EFL] Process launcher uses system() for wrapping the WebProcess when using WEB_PROCESS_CMD_PREFIX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105156





--- Comment #21 from Christophe Dumez <dchris at gmail.com>  2013-05-13 06:25:23 PST ---
(From update of attachment 201462)
View in context: https://bugs.webkit.org/attachment.cgi?id=201462&action=review

>>>> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:67
>>>> +        args[i] = new char[param.length() + 1];
>>> 
>>> why '+1' ?
>> 
>> For the ending '\0' character I assume.
>> "The strlen() function calculates the length of the string s, excluding the terminating null byte ('\0')."
>> 
>> strlen() is called inside CString.
> 
> than we should probably set last byte to null.

Agreed, would be safer indeed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.