[Webkit-unassigned] [Bug 116018] New: [WK2] ENABLE(NETSCAPE_PLUGIN_API) guarded in PluginInfoStore.h but not in PluginInformation.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 13 02:28:54 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=116018

           Summary: [WK2] ENABLE(NETSCAPE_PLUGIN_API) guarded in
                    PluginInfoStore.h but not in PluginInformation.cpp
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zarvai at inf.u-szeged.hu
                CC: andersca at apple.com, sam at webkit.org, zeno at webkit.org
            Blocks: 115891


New file Shared/Plugins/Netscape/PluginInformation.cpp landed in http://trac.webkit.org/changeset/149904 includes WebKit2/UIProcess/Plugins/PluginInfoStore.h and refers to it in line 103 with:
 map.set(pluginInformationDefaultLoadPolicyKey(), WebUInt64::create(toWKPluginLoadPolicy(PluginInfoStore::policyForPlugin(plugin))));

If NETSCAPE_PLUGIN_API is not enabled, then the build will fail, because ENABLE(NETSCAPE_PLUGIN_API) guarded in PluginInfoStore.h but not in PluginInformation.cpp. 

It seems that happened on Qt Mountain Lion bot:

/Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp:103:93: error: use of undeclared identifier 'PluginInfoStore'
    map.set(pluginInformationDefaultLoadPolicyKey(), WebUInt64::create(toWKPluginLoadPolicy(PluginInfoStore::policyForPlugin(plugin))));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list