[Webkit-unassigned] [Bug 115890] [EFL] Implement colorpicker for HTML5 input type color on Minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115890





--- Comment #2 from Jinwoo Song <jinwoo7.song at samsung.com>  2013-05-12 18:09:26 PST ---
(From update of attachment 201512)
View in context: https://bugs.webkit.org/attachment.cgi?id=201512&action=review

> Tools/ChangeLog:3
> +        [EFL]Implement colorpicker for HTML5 input type color on Minibrowser

s/colorpicker/color picker UI/ ?

> Tools/MiniBrowser/efl/main.c:67
> +

Unnecessary modification.

> Tools/MiniBrowser/efl/main.c:95
> +    Ewk_Color_Picker *colorPicker;

s/colorPicker/color_picker/

> Tools/MiniBrowser/efl/main.c:605
> +on_changed_color(void *data, Evas_Object *obj, void *event_info)

on_color_changed?

> Tools/MiniBrowser/efl/main.c:608
> +    Color_Picker_Data *cp_data = (Color_Picker_Data *) data;

Remove blank after right bracket.

> Tools/MiniBrowser/efl/main.c:618
> +    Color_Picker_Data *cp_data = (Color_Picker_Data *) data;

ditto.

> Tools/MiniBrowser/efl/main.c:619
> +    Elm_Object_Item *color_item = (Elm_Object_Item *) event_info;

ditto.

> Tools/MiniBrowser/efl/main.c:661
> +    window->color_selector = elm_win_add(window->elm_window, "color selector", ELM_WIN_DIALOG_BASIC);

IMO, we should use a modal popup instead of elm_window.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.