[Webkit-unassigned] [Bug 115969] New: Value of FrameLoadTypeSame is suspicious

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 11 14:51:35 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=115969

           Summary: Value of FrameLoadTypeSame is suspicious
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Page Loading
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: simon.fraser at apple.com
                CC: beidson at apple.com


This seems wrong:

    enum FrameLoadType {
        FrameLoadTypeStandard,
        FrameLoadTypeBack,
        FrameLoadTypeForward,
        FrameLoadTypeIndexedBackForward, // a multi-item hop in the backforward list
        FrameLoadTypeReload,
        // Skipped value: 'FrameLoadTypeReloadAllowingStaleData', still present in mac/win public API. Ready to be reused
        FrameLoadTypeSame = FrameLoadTypeReload + 2, // user loads same URL again (but not reload button)
        FrameLoadTypeRedirectWithLockedBackForwardList, // FIXME: Merge "lockBackForwardList", "lockHistory", "quickRedirect" and "clientRedirect" into a single concept of redirect.
        FrameLoadTypeReplace,
        FrameLoadTypeReloadFromOrigin,
    };


        FrameLoadTypeSame = FrameLoadTypeReload + 2, // user loads same URL again (but not reload button)
so FrameLoadTypeSame == FrameLoadTypeRedirectWithLockedBackForwardList ?

And isn't FrameLoadTypeSame supposed to match WebFrameLoadTypeSame in WebKit?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list